I do think that Camilla's legacy will be different with different generations. For those who remember the 80's and 90's, Charles and Camilla's affair and Charles & Diana's marriage and divorce, Camilla will be known mostly as "the other woman", because, at that time, that's the most well-known thing she was. Of course, some will view her as a conniving homewrecker, while others will see her as a tragic figure. For those in the generation who were born in the 90's and today, she will probably be known as the Prince of Wales' wife, and, when Charles succeeds the throne (allowing that he or Camilla do not predecease Queen Elizabeth), she will be known as the Princess Consort or Queen Consort, and for all of the good things she does, charities, etc.